r98037 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98036‎ | r98037 | r98038 >
Date:21:41, 24 September 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
small fixes
Modified paths:
  • /trunk/extensions/SemanticMaps/includes/SM_GeoCoordsHooks.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php
@@ -306,9 +306,7 @@
307307 * @return array
308308 */
309309 public final function getResult( SMWQueryResult $results, array $params, $outputmode ) {
310 - // Skip checks, results with 0 entries are normal.
311 - $this->readParameters( $params, $outputmode );
312 -
 310+ $this->handleParameters( $params, $outputmode );
313311 return $this->getResultText( $results, SMW_OUTPUT_HTML );
314312 }
315313
Index: trunk/extensions/SemanticMaps/includes/SM_GeoCoordsHooks.php
@@ -32,7 +32,7 @@
3333 if ( $format === false ) {
3434 // Only apply when there is more then one print request.
3535 // This way requests comming from #show are ignored.
36 - if ( count( $printRequests ) > 0 ) {
 36+ if ( count( $printRequests ) > 1 ) {
3737 $allValid = true;
3838 $hasCoords = false;
3939