r98014 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98013‎ | r98014 | r98015 >
Date:18:17, 24 September 2011
Author:maxsem
Status:ok
Tags:
Comment:
Use spinner on Special:Hieroglyphs
Modified paths:
  • /trunk/extensions/wikihiero/modules/ext.wikihiero.Special.js (modified) (history)
  • /trunk/extensions/wikihiero/wikihiero.php (modified) (history)

Diff [purge]

Index: trunk/extensions/wikihiero/wikihiero.php
@@ -60,6 +60,7 @@
6161 'styles' => 'ext.wikihiero.Special.css',
6262 'localBasePath' => dirname( __FILE__ ) . '/modules',
6363 'remoteExtPath' => 'wikihiero/modules',
 64+ 'dependencies' => array( 'jquery.spinner' ),
6465 'messages' => array(
6566 'wikihiero-input',
6667 'wikihiero-result',
Index: trunk/extensions/wikihiero/modules/ext.wikihiero.Special.js
@@ -16,6 +16,7 @@
1717 $submit.click( function( e ) {
1818 e.preventDefault();
1919 $result.hide();
 20+ $result.injectSpinner( 'hiero' );
2021 var text = $textarea.val();
2122 var data = {
2223 'format': 'json',
@@ -31,6 +32,7 @@
3233 + mw.msg( 'wikihiero-result' ) + '</th></tr>'
3334 + '<tr><td><code>&lt;hiero&gt;' + mw.html.escape( text ) + '&lt;/hiero&gt;</code></td>'
3435 + '<td>' + data.parse.text['*'] + '</td></tr></table>';
 36+ $.removeSpinner( 'hiero' );
3537 $result.html( html );
3638 $result.show();
3739 }

Status & tagging log