r97996 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97995‎ | r97996 | r97997 >
Date:12:24, 24 September 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
clarified docs
Modified paths:
  • /trunk/extensions/Validator/includes/Validator.php (modified) (history)
  • /trunk/extensions/Validator/includes/criteria/CriterionInRange.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Validator/includes/criteria/CriterionInRange.php
@@ -14,7 +14,7 @@
1515 class CriterionInRange extends ItemParameterCriterion {
1616
1717 /**
18 - * Lower bound of the range. Either a number or false, for no lower limit.
 18+ * Lower bound of the range (included). Either a number or false, for no lower limit.
1919 *
2020 * @since 0.4
2121 *
@@ -23,7 +23,7 @@
2424 protected $lowerBound;
2525
2626 /**
27 - * Upper bound of the range. Either a number or false, for no upper limit.
 27+ * Upper bound of the range (included). Either a number or false, for no upper limit.
2828 *
2929 * @since 0.4
3030 *
Index: trunk/extensions/Validator/includes/Validator.php
@@ -250,11 +250,12 @@
251251 break;
252252 }
253253 else {
 254+
254255 $parameter->validate( $this->parameters );
255256
256257 foreach ( $parameter->getErrors() as $error ) {
257258 $this->registerError( $error );
258 - }
 259+ }
259260
260261 if ( $parameter->hasFatalError() ) {
261262 // If there was a fatal error, and the parameter is required, stop processing.
@@ -299,7 +300,7 @@
300301 // Loop over the parameters to handle to create a dependency list.
301302 foreach ( $this->paramsTohandle as $paramName ) {
302303 $dependencies = array();
303 -
 304+
304305 // Only include dependencies that are in the list of parameters to handle.
305306 foreach ( $this->parameters[$paramName]->getDependencies() as $dependency ) {
306307 if ( in_array( $dependency, $this->paramsTohandle ) ) {