r97992 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97991‎ | r97992 | r97993 >
Date:11:47, 24 September 2011
Author:catrope
Status:ok
Tags:
Comment:
Fix notice in r97972. I figured getArray would return, well, an *array*, but it seems to return null if the parameter is missing.
Modified paths:
  • /trunk/extensions/MoodBar/SpecialMoodBarFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/SpecialMoodBarFeedback.php
@@ -49,7 +49,7 @@
5050 $whatIsMsg = wfMessage( 'moodbar-feedback-whatis' )->escaped();
5151 $whatIsURL = htmlspecialchars( $wgMoodBarConfig['infoUrl'] );
5252
53 - $types = $wgRequest->getArray( 'type' );
 53+ $types = $wgRequest->getArray( 'type', array() );
5454 $happyCheckbox = Xml::check( 'type[]', in_array( 'happy', $types ),
5555 array( 'id' => 'fbd-filters-type-praise', 'value' => 'happy' ) );
5656 $confusedCheckbox = Xml::check( 'type[]', in_array( 'confused', $types ),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97972Followup r97968, preserve form valuescatrope23:02, 23 September 2011

Status & tagging log