r97882 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97881‎ | r97882 | r97883 >
Date:01:10, 23 September 2011
Author:brion
Status:ok
Tags:
Comment:
MFT r92752 - remove mw.util.inArray function that got added just before the 1.18 branch point, then removed as redundant.

Don't want people to accidentally use it and have their code break on 1.19. :)

Don't seem to be any usages; only at orig commit time was in mediawiki.page.ajaxCategories.js which has since been removed.
Modified paths:
  • /branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.util.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.util.js
——@@ -109,17 +109,6 @@
110110 /* Main body */
111111
112112 /**
113 - * Wether a value is in an array. Using jQuery's inArray cross-browser utility,
114 - * (for browsers without Array indexOf support).
115 - * @param val {Mixed} Needle
116 - * @param arr {Array} Haystack
117 - * @return Boolean
118 - */
119 - 'inArray' : function( val, arr ) {
120 - return $.inArray( val, arr ) !== -1;
121 - },
122 -
123 - /**
124113 * Encode the string like PHP's rawurlencode
125114 *
126115 * @param str string String to be encoded

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92752Remove mw.util.inArray...krinkle16:41, 21 July 2011

Status & tagging log