r97819 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97818‎ | r97819 | r97820 >
Date:15:48, 22 September 2011
Author:raymond
Status:ok (Comments)
Tags:lamecommitsummary 
Comment:
Some message tweaks,
Add extension per r97061 to translatewiki.net
Modified paths:
  • /trunk/extensions/LinkFilter/Link.php (modified) (history)
  • /trunk/extensions/LinkFilter/LinkFilter.i18n.php (modified) (history)
  • /trunk/extensions/Translate/groups/mediawiki-defines.txt (modified) (history)

Diff [purge]

Index: trunk/extensions/LinkFilter/Link.php
@@ -23,10 +23,11 @@
2424
2525 // Extension credits that will show up on Special:Version
2626 $wgExtensionCredits['other'][] = array(
 27+ 'path' => __FILE__,
2728 'name' => 'LinkFilter',
28 - 'version' => '2.0',
 29+ 'version' => '2.0.1',
2930 'author' => array( 'Aaron Wright', 'David Pean', 'Jack Phoenix' ),
30 - 'description' => 'Adds some new special pages and a parser hook for link submitting/approval/reject',
 31+ 'descriptionmsg' => 'linkfilter-desc',
3132 'url' => 'http://www.mediawiki.org/wiki/Extension:LinkFilter'
3233 );
3334
Index: trunk/extensions/LinkFilter/LinkFilter.i18n.php
@@ -13,30 +13,31 @@
1414 * @author David Pean <david.pean@gmail.com>
1515 */
1616 $messages['en'] = array(
17 - 'linkapprove' => 'Approve Links',
18 - 'linkshome' => 'Links Home',
19 - 'linksubmit' => 'Submit a Link',
 17+ 'linkapprove' => 'Approve links',
 18+ 'linkshome' => 'Links home',
 19+ 'linksubmit' => 'Submit a link',
 20+ 'linkfilter-desc' => 'Adds new special pages and a parser hook for link submitting/approval/reject',
2021 'linkfilter-nothing-to-approve' => 'There are currently no links awaiting approval.',
2122 'linkfilter-no-recently-approved' => 'No links have been approved recently.',
22 - 'linkfilter-no-links-at-all' => 'No links have been submitted yet or the link administrators haven\'t reviewed the submitted links yet.',
 23+ 'linkfilter-no-links-at-all' => 'No links have been submitted yet or the link administrators have not reviewed the submitted links yet.',
2324 'linkfilter-ago' => '$1 ago under <i>$2</i>',
2425 'linkfilter-all' => 'All',
2526 'linkfilter-submit' => 'Submit',
26 - 'linkfilter-submit-title' => 'Submit a Link',
 27+ 'linkfilter-submit-title' => 'Submit a link',
2728 'linkfilter-submit-no-title' => 'Please enter a title',
28 - 'linkfilter-submit-no-type' => 'Hey, pick a link type!',
 29+ 'linkfilter-submit-no-type' => 'Pick a link type.',
2930 'linkfilter-edit-title' => 'Edit $1',
30 - 'linkfilter-approve-links' => 'Approve Links',
 31+ 'linkfilter-approve-links' => 'Approve links',
3132 'linkfilter-submit-another' => 'Submit another link',
3233 'linkfilter-login-title' => 'Not logged in',
3334 'linkfilter-login-text' => 'You must be logged in to submit links.',
3435 'linkfilter-url' => 'URL',
3536 'linkfilter-title' => 'Title',
36 - 'linkfilter-type' => 'Link Type',
 37+ 'linkfilter-type' => 'Link type',
3738 'linkfilter-description' => 'Description',
38 - 'linkfilter-submit-button' => 'Submit Link',
39 - 'linkfilter-home-button' => 'Links Home',
40 - 'linkfilter-submit-success-title' => 'Link Submitted',
 39+ 'linkfilter-submit-button' => 'Submit link',
 40+ 'linkfilter-home-button' => 'Links home',
 41+ 'linkfilter-submit-success-title' => 'Link submitted',
4142 'linkfilter-submit-success-text' => 'Your link has been sent for approval',
4243 'linkfilter-instructions' => 'You can add some instructions for users [[MediaWiki:Linkfilter-instructions|here]]',
4344 'linkfilter-admin-instructions' => 'You can add some instructions for admins [[MediaWiki:Linkfilter-admin-instructions|here]]',
@@ -66,37 +67,37 @@
6768 7) If some dude is spamming, don't post his links. One is OK.<br />
6869 8) If someone is submitting really good stuff, let me me know -- s/he'd probably make a good admin.<br />",
6970 */
70 - 'linkfilter-admin-recent' => 'Recently Approved',
71 - 'linkfilter-approve-title' => 'Link Administration',
 71+ 'linkfilter-admin-recent' => 'Recently approved',
 72+ 'linkfilter-approve-title' => 'Link administration',
7273 'linkfilter-submittedby' => 'Submitted by',
7374 'linkfilter-submitted' => 'Submitted $1',
7475 'linkfilter-admin-accept' => 'Accept',
7576 'linkfilter-admin-reject' => 'Reject',
7677 'linkfilter-admin-reject-success' => 'The link was rejected',
7778 'linkfilter-admin-accept-success' => 'The link was accepted',
78 - 'linkfilter-in-the-news' => 'In the News',
79 - 'linkfilter-about-submitter' => 'About the Submitter',
80 - 'linkfilter-anonymous' => 'Anonymous Fanatic',
81 - 'linkfilter-comments-of-day' => 'Top Comments',
 79+ 'linkfilter-in-the-news' => 'In the news',
 80+ 'linkfilter-about-submitter' => 'About the submitter',
 81+ 'linkfilter-anonymous' => 'Anonymous fanatic',
 82+ 'linkfilter-comments-of-day' => 'Top comments',
8283 'linkfilter-comments' => '{{PLURAL:$1|$1 comment|$1 comments}}',
83 - 'linkfilter-home-title' => '$1 Links',
84 - 'linkfilter-home-title-all' => 'All Links',
 84+ 'linkfilter-home-title' => '$1 links',
 85+ 'linkfilter-home-title-all' => 'All kinks',
8586 'linkfilter-next' => 'next',
8687 'linkfilter-previous' => 'previous',
87 - 'linkfilter-description-max' => 'Maximum Characters',
 88+ 'linkfilter-description-max' => 'Maximum characters',
8889 'linkfilter-description-left' => '$1 left',
89 - 'linkfilter-popular-articles' => 'Don\'t Miss',
90 - 'linkfilter-new-links-title' => 'New Links',
 90+ 'linkfilter-popular-articles' => 'Do not miss',
 91+ 'linkfilter-new-links-title' => 'New links',
9192 'linkfilter-time-days' => '{{PLURAL:$1|one day|$1 days}}',
9293 'linkfilter-time-hours' => '{{PLURAL:$1|one hour|$1 hours}}',
9394 'linkfilter-time-minutes' => '{{PLURAL:$1|one minute|$1 minutes}}',
9495 'linkfilter-time-seconds' => '{{PLURAL:$1|one second|$1 seconds}}',
9596 'linkfilter-edit-summary' => 'new link',
9697 'linkfilter-no-results' => 'No pages found.',
97 - 'linkfilter-feed-title' => '{{SITENAME}} Links', // RSS feed title
 98+ 'linkfilter-feed-title' => '{{SITENAME}} links', // RSS feed title
9899 // For Special:ListUsers - new group
99 - 'group-linkadmin' => 'Link Administrators',
100 - 'group-linkadmin-member' => 'Link Administrator',
 100+ 'group-linkadmin' => 'Link administrators',
 101+ 'group-linkadmin-member' => 'Link administrator',
101102 // For Special:ListGroupRights
102103 'right-linkadmin' => 'Administrate user-submitted links',
103104 );
@@ -161,4 +162,4 @@
162163 'group-linkadmin' => 'Linkkien ylläpitäjät',
163164 'group-linkadmin-member' => 'Linkkien ylläpitäjä',
164165 'right-linkadmin' => 'Hallinnoida käyttäjien lähettämiä linkkejä',
165 -);
\ No newline at end of file
 166+);
Index: trunk/extensions/Translate/groups/mediawiki-defines.txt
@@ -731,6 +731,10 @@
732732 Lingo
733733 magicfile = Lingo/Lingo.i18n.magic.php
734734
 735+Link Filter
 736+optional = linkfilter-url
 737+aliasfile = LinkFilter/Link.alias.php
 738+
735739 Link OpenID
736740 optional = linkopenid-prefs, linkopenid-prefstext-xrdsurl
737741

Follow-up revisions

RevisionCommit summaryAuthorDate
r97820FU r97819/r97061: Add missing messaga 'grouppage-linkadmin'raymond15:57, 22 September 2011
r97822FU r97819: Move commented out message to the end of the 'en' section. It seem...raymond16:00, 22 September 2011
r97845fix typo (in r97819)robin20:03, 22 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97061phase II social tools: LinkFilter, allows users to submit links and privilege...ashley15:10, 14 September 2011

Comments

#Comment by Nicmavr (talk | contribs)   16:31, 22 September 2011
+	'linkfilter-home-title' => '$1 links',
+	'linkfilter-home-title-all' => 'All kinks',

Kinks? Looks like a typo to me.

-	'linkfilter-new-links-title' => 'New Links',
+	'linkfilter-popular-articles' => 'Do not miss',
+	'linkfilter-new-links-title' => 'New links',

I think "Don't miss" would be more appropriate for this.

#Comment by SPQRobin (talk | contribs)   20:38, 22 September 2011

Typo fixed in r97845

#Comment by Jack Phoenix (talk | contribs)   18:29, 22 September 2011

Marking as FIXME as per Nicmavr's comment above.

+1 for "Don't miss", too — it's not grammatically incorrect and looks better IMO.

#Comment by Siebrand (talk | contribs)   20:24, 22 September 2011

No message documentation present. This increases chances of incorrect translations, which is something we hope to avoid. Please add.

Status & tagging log