r97800 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97799‎ | r97800 | r97801 >
Date:07:03, 22 September 2011
Author:ariel
Status:ok
Tags:
Comment:
remove cruft that didn't all get cleaned up before commit in r95260, addressing fixme.
Modified paths:
  • /trunk/phase3/includes/Export.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Export.php
@@ -354,8 +354,6 @@
355355 * @ingroup Dump
356356 */
357357 class XmlDumpWriter {
358 - protected $firstPageWritten = 0, $lastPageWritten = 0, $pageInProgress = 0;
359 -
360358 /**
361359 * Returns the export schema version.
362360 * @return string
@@ -459,7 +457,6 @@
460458 $title = Title::makeTitle( $row->page_namespace, $row->page_title );
461459 $out .= ' ' . Xml::elementClean( 'title', array(), $title->getPrefixedText() ) . "\n";
462460 $out .= ' ' . Xml::element( 'id', array(), strval( $row->page_id ) ) . "\n";
463 - $this->pageInProgress = $row->page_id;
464461 if ( $row->page_is_redirect ) {
465462 $out .= ' ' . Xml::element( 'redirect', array() ) . "\n";
466463 }
@@ -480,10 +477,6 @@
481478 */
482479 function closePage() {
483480 return " </page>\n";
484 - //if ( !$this->firstPageWritten ) {
485 - // $this->firstPageWritten = $this->pageInProgress;
486 - //}
487 - //$this->lastPageWritten = $this->pageInProgress;
488481 }
489482
490483 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95260add functions that support close and rename of output files as they are being...ariel22:01, 22 August 2011

Status & tagging log