r97764 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97763‎ | r97764 | r97765 >
Date:20:42, 21 September 2011
Author:aaron
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/FlaggedRevs/dataclasses/FlaggedRevs.class.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/FlaggedRevs/dataclasses/FlaggedRevs.class.php
@@ -963,10 +963,10 @@
964964 # If this is an image page, store corresponding file info
965965 $fileData = array( 'name' => null, 'timestamp' => null, 'sha1' => null );
966966 if ( $title->getNamespace() == NS_FILE ) {
967 - # We must use ImagePage process cache on upload or get bitten by slave lag
968 - $file = $article instanceof ImagePage
969 - ? $article->getFile()
970 - : wfFindFile( $title );
 967+ # We must use WikiFilePage process cache on upload or get bitten by slave lag
 968+ $file = ( $article instanceof WikiFilePage || $article instanceof ImagePage )
 969+ ? $article->getFile() // uses up-to-date process cache on new uploads
 970+ : wfFindFile( $title, array( 'bypassCache' => true ) ); // skip cache; bug 31056
971971 if ( is_object( $file ) && $file->exists() ) {
972972 $fileData['name'] = $title->getDBkey();
973973 $fileData['timestamp'] = $file->getTimestamp();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97701* Fixed bug causing new uploads to give "template/file changes need review" m...aaron07:13, 21 September 2011
r97702Removed debugging code from r97701aaron07:15, 21 September 2011

Status & tagging log