r97757 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97756‎ | r97757 | r97758 >
Date:19:30, 21 September 2011
Author:robin
Status:ok
Tags:
Comment:
* follow-up r97636: decrease indentation & mention revision per Nikerabbit
* add @since for r97071
Modified paths:
  • /trunk/phase3/includes/parser/ParserOptions.php (modified) (history)
  • /trunk/phase3/languages/Language.php (modified) (history)
  • /trunk/phase3/languages/LanguageConverter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/ParserOptions.php
@@ -275,7 +275,7 @@
276276 *
277277 * @since 1.17
278278 * @param $forOptions Array
279 - * @param $title Title: will be used to get the page content language
 279+ * @param $title Title: will be used to get the page content language (since r97636)
280280 * @return \string Page rendering hash
281281 */
282282 public function optionsHash( $forOptions, $title = null ) {
Index: trunk/phase3/languages/LanguageConverter.php
@@ -1364,7 +1364,7 @@
13651365 if ( isset( $this->mVariantFlags[$variant] ) ) {
13661366 // then convert <text to convert> to current language
13671367 $this->mRules = $this->mConverter->autoConvert( $this->mRules,
1368 - $variant );
 1368+ $variant );
13691369 } else { // if current variant no in flags,
13701370 // then we check its fallback variants.
13711371 $variantFallbacks =
@@ -1376,7 +1376,7 @@
13771377 // then convert <text to convert> to fallback language
13781378 $this->mRules =
13791379 $this->mConverter->autoConvert( $this->mRules,
1380 - $variantFallback );
 1380+ $variantFallback );
13811381 break;
13821382 }
13831383 }
Index: trunk/phase3/languages/Language.php
@@ -3418,6 +3418,8 @@
34193419 /**
34203420 * Get all message keys for a given language. This is a faster alternative to
34213421 * array_keys( Language::getMessagesFor( $code ) )
 3422+ *
 3423+ * @since 1.19
34223424 * @param $code string Language code
34233425 * @return array of message keys (strings)
34243426 */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97071Introduce Language::getMessageKeysFor() and use it in ApiQueryAllmessagescatrope16:48, 14 September 2011
r97636Re-do several things of r96798 in preparation of re-doing the rest (there's a...robin15:55, 20 September 2011

Status & tagging log