r97751 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97750‎ | r97751 | r97752 >
Date:18:13, 21 September 2011
Author:preilly
Status:ok
Tags:
Comment:
fix for r95268 comment 21339 remove use of isset
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -57,7 +57,7 @@
5858 *
5959 * e.g., http://en.wikipedia.org/w/mobileRedirect.php
6060 */
61 -$wgMobileRedirectFormAction;
 61+$wgMobileRedirectFormAction = false;
6262
6363 $wgExtMobileFrontend = new ExtMobileFrontend();
6464
@@ -84,7 +84,7 @@
8585 }
8686
8787 class ExtMobileFrontend {
88 - const VERSION = '0.5.67';
 88+ const VERSION = '0.5.68';
8989
9090 /**
9191 * @var DOMDocument
@@ -259,7 +259,7 @@
260260 self::$code = $wgContLang->getCode();
261261
262262 $nonMobileServerBaseURL = str_replace( $wgMobileDomain, '.', $wgServer );
263 - self::$mobileRedirectFormAction = ( isset( $wgMobileRedirectFormAction ) ) ? $wgMobileRedirectFormAction : "{$nonMobileServerBaseURL}/w/mobileRedirect.php";
 263+ self::$mobileRedirectFormAction = ( $wgMobileRedirectFormAction !== false ) ? $wgMobileRedirectFormAction : "{$nonMobileServerBaseURL}/w/mobileRedirect.php";
264264
265265 self::$mainPageUrl = Title::newMainPage()->getLocalUrl();
266266 self::$randomPageUrl = $this->getRelativeURL( SpecialPage::getTitleFor( 'Randompage' )->getLocalUrl() );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95268fix for bug 26797preilly22:32, 22 August 2011

Status & tagging log