r97739 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97738‎ | r97739 | r97740 >
Date:14:57, 21 September 2011
Author:nikerabbit
Status:deferred
Tags:
Comment:
Remove check that prevents nesting aggregate message groups.
It would be shame to not allow it, given all the pain to write
code which handles nested groups.
Modified paths:
  • /trunk/extensions/Translate/Groups.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/Groups.php
@@ -588,12 +588,6 @@
589589 continue;
590590 }
591591
592 - /** @todo Figure out a better way to skip groups which are in
593 - * aggregate and as individual in the list. */
594 - if ( $group instanceof AggregateMessageGroup ) {
595 - continue;
596 - }
597 -
598592 $groups[$id] = $group;
599593 }
600594

Status & tagging log