r97710 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97709‎ | r97710 | r97711 >
Date:09:11, 21 September 2011
Author:ialex
Status:ok
Tags:
Comment:
Don't use isset() to check for null
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -288,7 +288,7 @@
289289 }
290290
291291 private function renderPortal( $name, $content, $msg = null, $hook = null ) {
292 - if ( !isset( $msg ) ) {
 292+ if ( $msg === null ) {
293293 $msg = $name;
294294 }
295295 ?>
@@ -304,7 +304,7 @@
305305
306306 <?php
307307 endforeach;
308 - if ( isset( $hook ) ) {
 308+ if ( $hook !== null ) {
309309 wfRunHooks( $hook, array( &$this ) );
310310 }
311311 ?>

Status & tagging log