r97641 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97640‎ | r97641 | r97642 >
Date:16:26, 20 September 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
I broke few parser tests in r97633 by overlooking the return value. This fixes them.
Modified paths:
  • /trunk/phase3/includes/cache/LinkCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/cache/LinkCache.php
——@@ -200,8 +200,10 @@
201201 # Set fields...
202202 if ( $s !== false ) {
203203 $this->addGoodLinkObjFromRow( $nt, $s );
 204+ $id = intval( $s->page_id );
204205 } else {
205206 $this->addBadLinkObj( $nt );
 207+ $id = 0;
206208 }
207209
208210 wfProfileOut( __METHOD__ );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97633Added LinkCache::addGoodLinkObjFromRow, since addGoodLinkObj is not going to ...nikerabbit15:19, 20 September 2011

Status & tagging log