r97612 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97611‎ | r97612 | r97613 >
Date:10:04, 20 September 2011
Author:reedy
Status:ok
Tags:
Comment:
REL1_18: MFT r97590, r97583
Modified paths:
  • /branches/REL1_18/extensions/TitleBlacklist (modified) (history)
  • /branches/REL1_18/extensions/TitleBlacklist/TitleBlacklist.list.php (modified) (history)
  • /branches/REL1_18/phase3/includes/profiler/ProfilerSimpleUDP.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/extensions/TitleBlacklist/TitleBlacklist.list.php
@@ -308,6 +308,9 @@
309309 * else false if it doesn't match (or was overridden)
310310 */
311311 public function matches( $title, $action ) {
 312+ if ( !$title ) {
 313+ return false;
 314+ }
312315 wfSuppressWarnings();
313316 $match = preg_match( "/^(?:{$this->mRegex})$/us" . ( isset( $this->mParams['casesensitive'] ) ? '' : 'i' ), $title->getFullText() );
314317 wfRestoreWarnings();
Property changes on: branches/REL1_18/extensions/TitleBlacklist
___________________________________________________________________
Added: svn:mergeinfo
315318 Merged /trunk/extensions/TitleBlacklist:r97583
Index: branches/REL1_18/phase3/includes/profiler/ProfilerSimpleUDP.php
@@ -13,7 +13,7 @@
1414 public function logData() {
1515 global $wgUDPProfilerHost, $wgUDPProfilerPort;
1616
17 - $this->collateData();
 17+ $this->close();
1818
1919 if ( isset( $this->mCollated['-total'] ) && $this->mCollated['-total']['real'] < $this->mMinimumTime ) {
2020 # Less than minimum, ignore

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97583<preilly> PHP fatal error in /usr/local/apache/common-local/php-1.18/extensio...reedy00:11, 20 September 2011
r97590Don't call Profiler::collateData() from ProfilerSimpleUDP, it destroys $this-...tstarling01:28, 20 September 2011

Status & tagging log