r97596 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97595‎ | r97596 | r97597 >
Date:06:03, 20 September 2011
Author:inez
Status:deferred
Tags:
Comment:
Small optimization
Modified paths:
  • /trunk/parsers/wikidom/lib/synth/views/es.TableBlockRowView.js (modified) (history)
  • /trunk/parsers/wikidom/lib/synth/views/es.TableBlockView.js (modified) (history)

Diff [purge]

Index: trunk/parsers/wikidom/lib/synth/views/es.TableBlockRowView.js
@@ -6,13 +6,8 @@
77 */
88 es.TableBlockRowView = function( model ) {
99 es.ViewList.call( this, model, $( '<tr>' ) );
10 - es.ViewListItem.call( this, model, this.$ );
11 -
12 - var classes = this.$.attr('class');
13 - for ( var name in this.model.attributes ) {
14 - this.$.attr( name, this.model.attributes[name] );
15 - }
16 - this.$.addClass(classes);
 10+ es.ViewListItem.call( this, model, this.$ );
 11+ this.$.attr( this.model.attributes );
1712 };
1813
1914 /**
Index: trunk/parsers/wikidom/lib/synth/views/es.TableBlockView.js
@@ -7,9 +7,7 @@
88 es.TableBlockView = function( model ) {
99 es.ViewList.call( this, model, $( '<table>' ) );
1010 es.BlockView.call( this, model, this.$ );
11 - for ( var name in this.model.attributes ) {
12 - this.$.attr( name, this.model.attributes[name] );
13 - }
 11+ this.$.attr( this.model.attributes );
1412 this.$.addClass( 'editSurface-tableBlock' );
1513 };
1614

Status & tagging log