r97535 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97534‎ | r97535 | r97536 >
Date:18:45, 19 September 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_Category.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/RELEASE-NOTES
@@ -14,7 +14,7 @@
1515 * Fixed display of properties of type URL (bug 30912).
1616 * Fixed hide query functionality on Special:Ask (bug 30768).
1717 * Fixed display of internal SMW helper constants in certain queries (bug 30969).
18 -* Fixed some issue with the category result format (including bug 30761).
 18+* Fixed some issues with the category result format (including bug 30761).
1919
2020 == SMW 1.6.1 ==
2121
Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_Category.php
@@ -72,9 +72,13 @@
7373 $nextrow = $res->getNext(); // look ahead
7474
7575 $content = $row[0]->getContent();
76 - $sortkey = $res->getStore()->getWikiPageSortKey( $content[0] );
77 - $cur_first_char = $wgContLang->firstChar( $sortkey == '' ? $content[0]->getDBkey() : $sortkey );
7876
 77+ $cur_first_char = $wgContLang->firstChar(
 78+ $content[0]->getDIType() == SMWDataItem::TYPE_WIKIPAGE ?
 79+ $res->getStore()->getWikiPageSortKey( $content[0] )
 80+ : $content[0]->getSortKey()
 81+ );
 82+
7983 if ( $rowindex % $rows_per_column == 0 ) {
8084 $result .= "\n <div style=\"float: left; width: $column_width%;\">\n";
8185 if ( $cur_first_char == $prev_first_char )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97507have the category format use new style param handling and fix bug 30761jeroendedauw15:34, 19 September 2011