r97457 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97456‎ | r97457 | r97458 >
Date:06:49, 19 September 2011
Author:yaron
Status:deferred
Tags:
Comment:
Input type dropdown for 'edit schema' can now accept a blank value
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_PageSchemas.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_PageSchemas.php
@@ -172,7 +172,7 @@
173173
174174 global $sfgFormPrinter;
175175 $possibleInputTypes = $sfgFormPrinter->getAllInputTypes();
176 - $inputTypeDropdownHTML = '';
 176+ $inputTypeDropdownHTML = Html::element( 'option', null, null );
177177 foreach ( $possibleInputTypes as $possibleInputType ) {
178178 $inputTypeOptionAttrs = array();
179179 if ( $possibleInputType == $inputType ) {
@@ -181,7 +181,7 @@
182182 $inputTypeDropdownHTML .= Html::element( 'option', $inputTypeOptionAttrs, $possibleInputType ) . "\n";
183183 }
184184 $inputTypeDropdown = Html::rawElement( 'select', array( 'name' => 'sf_input_type_num' ), $inputTypeDropdownHTML );
185 - $text = '<p>' . wfMsg( 'sf_createform_inputtype' ) . ' ' . $inputTypeDropdown . '</p>';
 185+ $text = '<p>' . wfMsg( 'sf-pageschemas-inputtype' ) . ' ' . $inputTypeDropdown . '</p>';
186186
187187 $text .= "\t" . '<p>Enter parameter names and their values as key=value pairs, separated by commas (if a value contains a comma, replace it with "\,") For example: size=20, mandatory</p>' . "\n";
188188 $paramValues = array();