r9745 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r9744‎ | r9745 | r9746 >
Date:16:35, 28 June 2005
Author:vibber
Status:old
Tags:
Comment:
* (bug 2576) Fix recording of transclusion links
Somehow we ended up with two copies of the same stuff in there, and they
stomped up the tables.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1210,22 +1210,9 @@
12111211 $wgLinkCache->clear();
12121212 }
12131213 }
 1214+
12141215 # Parse the text and replace links with placeholders
1215 - # Do this outside the locks on the links table
1216 - # The existence test queries need to be FOR UPDATE
1217 - #$oldUpdate = $wgParser->forUpdate( true );
12181216 $wgOut = new OutputPage();
1219 - $wgOut->addWikiTextWithTitle( $text, $this->mTitle );
1220 -
1221 - # Select for update
1222 - $wgLinkCache->forUpdate( true );
1223 -
1224 - # Get old version of link table to allow incremental link updates
1225 - $wgLinkCache->preFill( $this->mTitle );
1226 - $wgLinkCache->clear();
1227 -
1228 - # Parse the text and replace links with placeholders
1229 - $wgOut = new OutputPage();
12301217
12311218 # Pass the current title along in case we're creating a wiki page
12321219 # which is different than the currently displayed one (e.g. image
Index: trunk/phase3/RELEASE-NOTES
@@ -400,6 +400,7 @@
401401 * (bug 2560) Don't show blank width/height attributes for missing size
402402 * Don't show bogus messages about watchlist notifications when disabled
403403 * Don't show old debug messages in watchlist
 404+* (bug 2576) Fix recording of transclusion links
404405
405406
406407 === Caveats ===

Status & tagging log