r97382 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97381‎ | r97382 | r97383 >
Date:18:03, 17 September 2011
Author:krinkle
Status:ok
Tags:
Comment:
Use Skin->getCategories() instead of Skin->getCategoryLinks() and manually wrapping the #catlinks element around it. This to use the centralized output control, no need to duplicate the IDs and class names here.
* Also removing the conditional addition of <br />, which is no longer needed since <div> is a block level element which downs;t need a line break to start on a new line (this <br />) hasn't been needed since it's an unordered list (r92054)
* Follows-up r92054 and it's CR
Modified paths:
  • /trunk/phase3/skins/CologneBlue.php (modified) (history)
  • /trunk/phase3/skins/Nostalgia.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/CologneBlue.php
——@@ -77,10 +77,9 @@
7878
7979 $s .= '<font size="-1"><span id="langlinks">';
8080 $s .= str_replace( '<br />', '', $this->otherLanguages() );
81 - $cat = '<div id="catlinks" class="catlinks">' . $this->getSkin()->getCategoryLinks() . '</div>';
82 - if( $cat ) {
83 - $s .= "<br />$cat\n";
84 - }
 81+
 82+ $s .= $this->getSkin()->getCategories();
 83+
8584 $s .= '<br />' . $this->pageTitleLinks();
8685 $s .= '</span></font>';
8786
Index: trunk/phase3/skins/Nostalgia.php
——@@ -54,10 +54,7 @@
5555 $s .= '<br />' . $ol;
5656 }
5757
58 - $cat = '<div id="catlinks" class="catlinks">' . $this->getSkin()->getCategoryLinks() . '</div>';
59 - if( $cat ) {
60 - $s .= '<br />' . $cat;
61 - }
 58+ $s .= $this->getSkin()->getCategories();
6259
6360 $s .= "<br clear='all' /></div><hr />\n</div>\n";
6461 $s .= "\n<div id='article'>";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92054Render category links as an HTML list. Bug 12261. Based on patch by Thana & B...diebuche10:41, 13 July 2011

Status & tagging log