r97371 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97370‎ | r97371 | r97372 >
Date:07:18, 17 September 2011
Author:ning
Status:deferred
Tags:
Comment:
Bug: SMW 1.5.x uses DBKey as smw_title
Modified paths:
  • /trunk/extensions/SemanticNotifyMe/includes/SMW_NotifyProcessor.smw15.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticNotifyMe/includes/SMW_NotifyProcessor.smw15.php
@@ -1151,13 +1151,13 @@
11521152 if ( $property->getWikiValue() != '' ) {
11531153 foreach ( $propvalues as $propvalue ) {
11541154 if ( $propvalue->getWikiValue() != '' ) {
1155 - $result[SMWNotifyProcessor::toInfoId( 2, 0, $sStore->lookupSmwId( SMW_NS_PROPERTY, $property->getWikiValue() ) )][] = array( 'name' => $property, 'value' => $propvalue );
 1155+ $result[SMWNotifyProcessor::toInfoId( 2, 0, $sStore->lookupSmwId( SMW_NS_PROPERTY, $property->getDBkey() ) )][] = array( 'name' => $property, 'value' => $propvalue );
11561156 }
11571157 }
11581158 } else {
11591159 foreach ( $propvalues as $propvalue ) {
11601160 if ( ( $propvalue instanceof SMWWikiPageValue ) && ( $propvalue->getNamespace() == NS_CATEGORY ) ) {
1161 - $result[SMWNotifyProcessor::toInfoId( 0, 0, $sStore->lookupSmwId( NS_CATEGORY, $propvalue->getWikiValue() ) )][] = array( 'name' => $propvalue, 'value' => null );
 1161+ $result[SMWNotifyProcessor::toInfoId( 0, 0, $sStore->lookupSmwId( NS_CATEGORY, $propvalue->getDBkey() ) )][] = array( 'name' => $propvalue, 'value' => null );
11621162 }
11631163 }
11641164 }
@@ -1578,6 +1578,9 @@
15791579 $res = smwfGetStore()->getQueryResult( $query );
15801580 $printer = SMWQueryProcessor::getResultPrinter( $format, SMWQueryProcessor::INLINE_QUERY, $res );
15811581 $result = $printer->getResult( $res, $params, SMW_OUTPUT_HTML );
 1582+ // FIXME: hardcode switch to full url
 1583+ global $wgScriptPath, $wgServer;
 1584+ $result = str_replace ( $wgScriptPath, $wgServer . $wgScriptPath, $result );
15821585 $html_msg .= $result . '<br/>';
15831586 $html_showall[$notify_id] = array ( 'name' => $notifications[$notify_id]['name'], 'html' => $result );
15841587