r97330 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97329‎ | r97330 | r97331 >
Date:20:31, 16 September 2011
Author:sean_colombo
Status:ok
Tags:
Comment:
Additional register_globals vulnerability check. Merged in from big Wikia merge: http://www.mediawiki.org/wiki/Wikia_code
Modified paths:
  • /trunk/phase3/includes/WebStart.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WebStart.php
@@ -26,7 +26,7 @@
2727 # Protect against register_globals
2828 # This must be done before any globals are set by the code
2929 if ( ini_get( 'register_globals' ) ) {
30 - if ( isset( $_REQUEST['GLOBALS'] ) ) {
 30+ if ( isset( $_REQUEST['GLOBALS'] ) || isset( $_FILES['GLOBALS'] ) ) {
3131 die( '<a href="http://www.hardened-php.net/globals-problem">$GLOBALS overwrite vulnerability</a>');
3232 }
3333 $verboten = array(

Status & tagging log