r97290 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97289‎ | r97290 | r97291 >
Date:15:20, 16 September 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
revert r97288; interface is proposed but does not exist yet - I failed
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_Category.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_List.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_QueryUI.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_QueryUI.php
@@ -525,11 +525,9 @@
526526 }
527527 $result .= Html::openElement(
528528 'div',
529 - array(
530 - 'id' => 'smwmainlabel',
 529+ array( 'id' => 'smwmainlabel',
531530 'class' => 'smwsort',
532 - 'style' => array( 'display' => $formDisplay )
533 - )
 531+ 'style' => "display:$formDisplay;" )
534532 ) .
535533 Html::openElement( 'span',
536534 array( 'class' => 'smwquisortlabel' ) ) .
@@ -1730,7 +1728,7 @@
17311729 $resultHtml .= Html::rawElement(
17321730 'div',
17331731 array(
1734 - 'style' => array( 'background' => $flipStyle ? 'white' : '#dddddd' ) )
 1732+ 'style' => 'background: ' . ( $flipStyle ? 'white' : '#dddddd' ) . ';'
17351733 ),
17361734 $rowHtml
17371735 );
Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_List.php
@@ -106,14 +106,7 @@
107107 // Set up floating divs, if there's more than one column
108108 if ( $this->mColumns > 1 ) {
109109 $column_width = floor( 100 / $this->mColumns );
110 -
111 - $result .= Html::openElement(
112 - 'div',
113 - array(
114 - 'style' => array( 'float' => 'left', 'width' => "$column_width%" )
115 - )
116 - );
117 -
 110+ $result .= '<div style="float: left; width: ' . $column_width . '%">' . "\n";
118111 $rows_per_column = ceil( $res->getCount() / $this->mColumns );
119112 $rows_in_cur_column = 0;
120113 }
Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_Category.php
@@ -69,14 +69,9 @@
7070 $cur_first_char = $wgContLang->firstChar( $sortkey == '' ? $content[0]->getDBkey() : $sortkey );
7171
7272 if ( $rowindex % $rows_per_column == 0 ) {
73 - $result .= Html::openElement( 'div', array( 'style' => array(
74 - 'float' => 'left',
75 - 'width' => "$column_width%"
76 - ) ) );
77 -
78 - if ( $cur_first_char == $prev_first_char ) {
 73+ $result .= "\n <div style=\"float: left; width: $column_width%;\">\n";
 74+ if ( $cur_first_char == $prev_first_char )
7975 $result .= " <h3>$cur_first_char " . wfMsg( 'listingcontinuesabbrev' ) . "</h3>\n <ul>\n";
80 - }
8176 }
8277
8378 // if we're at a new first letter, end

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97288use style args that are escaped; not strictrly needed here as the vars have a...jeroendedauw15:12, 16 September 2011