r97271 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97270‎ | r97271 | r97272 >
Date:14:12, 16 September 2011
Author:reedy
Status:ok
Tags:
Comment:
REL1_18 MFT r96406
Modified paths:
  • /branches/REL1_18/extensions/Collection/Collection.hooks.php (modified) (history)
  • /branches/REL1_18/extensions/Collection/Collection.templates.php (modified) (history)
  • /branches/REL1_18/extensions/Collection/js/bookcreator.css (modified) (history)
  • /branches/REL1_18/phase3/includes/HistoryPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialFileDuplicateSearch.php (modified) (history)
  • /branches/REL1_18/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: branches/REL1_18/extensions/Collection/Collection.hooks.php
@@ -245,7 +245,7 @@
246246 'alt' => '',
247247 'width' => '80',
248248 'height' => '45',
249 - 'class' => 'mw-float-start collection-creatorbox-book',
 249+ 'class' => 'collection-creatorbox-book',
250250 ),
251251 '',
252252 true
@@ -253,8 +253,7 @@
254254
255255 $html .= Xml::tags( 'div',
256256 array( 'class' => 'collection-creatorbox-row' ),
257 - Xml::tags( 'div',
258 - array( 'class' => 'mw-float-end' ),
 257+ Xml::tags( 'div', null,
259258 $skin->link(
260259 Title::newFromText( wfMsg( 'coll-helppage' ) ),
261260 Xml::element( 'img',
@@ -263,7 +262,6 @@
264263 'alt' => '',
265264 'width' => '16',
266265 'height' => '16',
267 - 'style' => 'vertical-align: text-bottom;',
268266 )
269267 )
270268 . ' ' . wfMsgHtml( 'coll-help' ),
Index: branches/REL1_18/extensions/Collection/js/bookcreator.css
@@ -13,6 +13,7 @@
1414 */
1515
1616 .collection-column {
 17+ float: left;
1718 width: 47%;
1819 }
1920
@@ -116,6 +117,10 @@
117118 margin-bottom: 0;
118119 }
119120
 121+.collection-creatorbox-book {
 122+ float: left;
 123+}
 124+
120125 /* Trivial but nicer for the browsers that support it */
121126 .rtl .collection-creatorbox-book {
122127 --ms-transform: scaleX(-1);
@@ -134,6 +139,18 @@
135140 margin-left: 10px;
136141 }
137142
 143+.collection-creatorbox-row div {
 144+ float: right;
 145+}
 146+
138147 .collection-creatorbox-row img {
139148 vertical-align: text-bottom;
140 -}
\ No newline at end of file
 149+}
 150+
 151+#collection-suggest-add,
 152+#collection-order-button,
 153+#collection-download-button,
 154+#collection-save-button,
 155+#collection-save-input {
 156+ float: right;
 157+}
Index: branches/REL1_18/extensions/Collection/Collection.templates.php
@@ -15,7 +15,7 @@
1616 $mediapath = $GLOBALS['wgScriptPath'] . '/extensions/Collection/images/';
1717 ?>
1818
19 -<div class="mw-float-start collection-column collection-column-left">
 19+<div class="collection-column collection-column-left">
2020
2121 <form action="<?php echo htmlspecialchars( SkinTemplate::makeSpecialUrl( 'Book' ) ) ?>" method="post" id="mw-collection-title-form">
2222 <table id="mw-collection-title-table" style="width: 80%; background-color: transparent;" align="center">
@@ -51,7 +51,7 @@
5252
5353 </div>
5454
55 -<div class="mw-float-start collection-column collection-column-right">
 55+<div class="collection-column collection-column-right">
5656
5757 <div class="collection-column-right-box">
5858 <h2><span class="mw-headline"><?php $this->msg( 'coll-book_title' ) ?></span></h2>
@@ -60,7 +60,7 @@
6161 $this->msgWiki( 'coll-book_text' );
6262 ?>
6363 <div>
64 - <div class="mw-float-end">
 64+ <div id="collection-order-button">
6565 <form action="<?php echo htmlspecialchars( SkinTemplate::makeSpecialUrl( 'Book' ) ) ?>" method="post">
6666 <input type="hidden" name="bookcmd" value="post_zip" />
6767 <input type="hidden" name="partner" value="pediapress" />
@@ -112,7 +112,7 @@
113113 <?php } ?>
114114 </select>
115115 <?php } ?>
116 - </td><td class="mw-align-end" style="vertical-align:bottom;">
 116+ </td><td id="collection-download-button">
117117 <input type="hidden" name="bookcmd" value="render" />
118118 <input id="downloadButton" type="submit" value="<?php echo $buttonLabel ?>"<?php if ( count( $this->data['collection']['items'] ) == 0 ) { ?> disabled="disabled"<?php } ?> />
119119 </td></tr></tbody></table>
@@ -146,7 +146,7 @@
147147 <?php } ?>
148148 <label for="personalCollTitle"><a href="<?php echo htmlspecialchars( SkinTemplate::makeSpecialUrl( 'Prefixindex', 'prefix=' . wfUrlencode( $this->data['user-book-prefix'] ) ) ) ?>"><?php echo htmlspecialchars( $this->data['user-book-prefix'] ) ?></a></label>
149149 </td>
150 - <td class="mw-align-end">
 150+ <td id="collection-save-input">
151151 <input id="personalCollTitle" type="text" name="pcollname" />
152152 </td></tr>
153153 <?php } // if ($canSaveUserPage) ?>
@@ -159,11 +159,11 @@
160160 <?php } ?>
161161 <label for="communityCollTitle"><a href="<?php echo htmlspecialchars( SkinTemplate::makeSpecialUrl( 'Prefixindex', 'prefix=' . wfUrlencode( $this->data['community-book-prefix'] ) ) ) ?>"><?php echo htmlspecialchars( $this->data['community-book-prefix'] ) ?></a></label>
162162 </td>
163 - <td class="mw-align-end">
 163+ <td id="collection-save-button">
164164 <input id="communityCollTitle" type="text" name="ccollname" disabled="disabled" />
165165 </td></tr>
166166 <?php } // if ($canSaveCommunityPage) ?>
167 - <tr><td>&#160;</td><td class="mw-align-end">
 167+ <tr><td>&#160;</td><td id="collection-save-button">
168168 <input id="saveButton" type="submit" value="<?php $this->msg( 'coll-save_collection' ) ?>"<?php if ( count( $this->data['collection']['items'] ) == 0 ) { ?> disabled="disabled"<?php } ?> />
169169 </tr></tbody></table>
170170 <input name="token" type="hidden" value="<?php echo htmlspecialchars( $GLOBALS['wgUser']->editToken() ) ?>" />
@@ -418,7 +418,7 @@
419419 (<a href="<?php echo htmlspecialchars( SkinTemplate::makeSpecialUrl( 'Book', array( 'bookcmd' => 'suggest', 'resetbans' => '1' ) ) ) ?>" title="<?php $this->msg( 'coll-suggest_reset_bans_tooltip' ) ?>"><?php $this->msg( 'coll-suggest_reset_bans' ) ?></a>)
420420 <?php if ( count( $this->data['proposals'] ) > 0 ) { ?>
421421 <noscript>
422 - <div class="mw-float-end">
 422+ <div id="collection-suggest-add">
423423 <input type="submit" value="<?php $this->msg( 'coll-suggest_add_selected' ) ?>" name="addselected" />
424424 </div>
425425 </noscript>
Index: branches/REL1_18/phase3/skins/common/shared.css
@@ -18,11 +18,6 @@
1919 /* @noflip */textarea[dir="ltr"], input[dir="ltr"] { direction: ltr; }
2020 /* @noflip */textarea[dir="rtl"], input[dir="rtl"] { direction: rtl; }
2121
22 -.mw-float-start { float: left; }
23 -.mw-float-end { float: right; }
24 -.mw-align-start { text-align: left; }
25 -.mw-align-end { text-align: right; }
26 -
2722 /* The scripts of these languages are very hard to read with underlines */
2823 [lang="ar"] a, [lang="ckb"] a, [lang="fa"] a, [lang="kk-arab"] a,
2924 [lang="mzn"] a, [lang="ps"] a, [lang="ur"] a {
@@ -296,6 +291,10 @@
297292 border: 1px dashed #aaa;
298293 }
299294
 295+.mw-history-revisiondelete-button, #mw-fileduplicatesearch-icon {
 296+ float: right;
 297+}
 298+
300299 /** Generic minor/bot/newpage styling */
301300 .newpage, .minor, .bot {
302301 font-weight: bold;
Index: branches/REL1_18/phase3/includes/HistoryPage.php
@@ -420,7 +420,7 @@
421421 'type' => 'submit',
422422 'name' => $name,
423423 'value' => '1',
424 - 'class' => "mw-history-$name-button mw-float-end",
 424+ 'class' => "mw-history-$name-button",
425425 ),
426426 wfMsg( $msg )
427427 ) . "\n";
Property changes on: branches/REL1_18/phase3/includes/HistoryPage.php
___________________________________________________________________
Modified: svn:mergeinfo
428428 Merged /trunk/phase3/includes/HistoryPage.php:r96406
Index: branches/REL1_18/phase3/includes/specials/SpecialFileDuplicateSearch.php
@@ -131,7 +131,7 @@
132132 if ( $img ) {
133133 $thumb = $img->transform( array( 'width' => 120, 'height' => 120 ) );
134134 if( $thumb ) {
135 - $wgOut->addHTML( '<div class="mw-float-end" id="mw-fileduplicatesearch-icon">' .
 135+ $wgOut->addHTML( '<div id="mw-fileduplicatesearch-icon">' .
136136 $thumb->toHtml( array( 'desc-link' => false ) ) . '<br />' .
137137 wfMsgExt( 'fileduplicatesearch-info', array( 'parse' ),
138138 $wgLang->formatNum( $img->getWidth() ),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96406Per Krinke on r91772, do not use general float/align classes. I removed them ...robin05:23, 7 September 2011

Status & tagging log