r97255 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97254‎ | r97255 | r97256 >
Date:12:24, 16 September 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r97223;
Modified paths:
  • /trunk/extensions/Maps/includes/manipulations/Maps_ParamGeoService.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/includes/manipulations/Maps_ParamGeoService.php
@@ -28,7 +28,6 @@
2929 */
3030 public function __construct( $mappingServiceParam = false ) {
3131 parent::__construct();
32 -
3332 $this->mappingServiceParam = $mappingServiceParam;
3433 }
3534
@@ -49,7 +48,9 @@
5049 $value = $this->getMainIndentifier( $value );
5150
5251 // Override the defaulting.
53 - if ( $parameter->wasSetToDefault() && $this->mappingServiceParam !== false ) {
 52+ if ( $parameter->wasSetToDefault()
 53+ && is_string( $this->mappingServiceParam )
 54+ && array_key_exists( $this->mappingServiceParam, $parameters ) ) {
5455 $value = self::resolveOverrides( $value, $parameters[$this->mappingServiceParam]->getValue() );
5556 }
5657

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97223changing param handling to happen on query processor level instead of in the ...jeroendedauw00:26, 16 September 2011