r97243 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97242‎ | r97243 | r97244 >
Date:06:34, 16 September 2011
Author:nikerabbit
Status:deferred
Tags:
Comment:
updateTransverTag is now a hook, which needs to return true.
Followup r97171
Modified paths:
  • /trunk/extensions/Translate/TranslateEditAddons.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslateEditAddons.php
@@ -405,14 +405,14 @@
406406 $group = $handle->getGroup();
407407 if ( $group instanceof WikiPageMessageGroup ) {
408408 // WikiPageMessageGroup has different method
409 - return;
 409+ return true;
410410 }
411411
412412 $title = $handle->getTitle();
413413 $name = $handle->getKey() . '/' . $group->getSourceLanguage();
414414 $definitionTitle = Title::makeTitleSafe( $title->getNamespace(), $name );
415415 if ( !$definitionTitle || !$definitionTitle->exists() ) {
416 - return;
 416+ return true;
417417 }
418418
419419 $definitionRevision = $definitionTitle->getLatestRevID();
@@ -427,6 +427,7 @@
428428 );
429429 $index = array( 'rt_type', 'rt_page', 'rt_revision' );
430430 $dbw->replace( 'revtag', array( $index ), $conds, __METHOD__ );
 431+ return true;
431432 }
432433
433434 public static function preserveWhitespaces( $text ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97171Convert code to use MessageHandle class....nikerabbit16:10, 15 September 2011

Status & tagging log