r97218 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97217‎ | r97218 | r97219 >
Date:23:14, 15 September 2011
Author:pgehres
Status:ok
Tags:
Comment:
Removed stray comma breaking IE
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_1.html (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_1a.html (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_2.html (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_1.html
@@ -196,7 +196,7 @@
197197 <p><a href="https://www.mediawiki.org/wiki/Ways_to_Give/en">More information or other ways to give</a><br /><a href="https://www.mediawiki.org/wiki/FAQ/en">Answers to frequently asked questions</a></p>
198198 </div>
199199 </div>
200 - <!-- load jquery 1.4.2 -->
 200+ <!-- load jquery (newer) -->
201201 <script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.js'></script>
202202 <script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.core.js'></script>
203203 <script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.widget.js'></script>
@@ -284,8 +284,8 @@
285285
286286 function validateAmount(){
287287 var minimums = {
288 - 'USD' : 1,
289 - }
 288+ 'USD' : 1
 289+ };
290290 var error = true;
291291 var amount = $("input[name=amount]").val(); // get the amount
292292 var otherAmount = amount // create a working copy
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_1a.html
@@ -284,8 +284,8 @@
285285
286286 function validateAmount(){
287287 var minimums = {
288 - 'USD' : 1,
289 - }
 288+ 'USD' : 1
 289+ };
290290 var error = true;
291291 var amount = $("input[name=amount]").val(); // get the amount
292292 var otherAmount = amount // create a working copy
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_2.html
@@ -26,9 +26,11 @@
2727 }
2828 #amount-table-white label { font-size: 1.1em; }
2929
 30+ #donate-body { width: 348px; }
3031 #donate-body h3 { font-size: 17px; }
3132
32 - #where-content { font-size: 13px; line-height: 19px; }
 33+ #step2wrapper { width: 325px; }
 34+ #where-content { font-size: 13px; line-height: 19px; width: 325px; }
3335
3436 </style>
3537
@@ -74,7 +76,7 @@
7577 </table>
7678
7779 <p class="donate-options">
78 - <input class="btn" id="cc" type="button" value="Donate by Credit Card" />
 80+ <input class="btn" id="cc" type="button" value="Donate by Credit Card" /><br />
7981 <input class="btn" id="pp" type="button" value="Donate via PayPal"/><span id='loading'></span>
8082 </p>
8183 </div>
@@ -315,8 +317,8 @@
316318
317319 function validateAmount(){
318320 var minimums = {
319 - 'USD' : 1,
320 - }
 321+ 'USD' : 1
 322+ };
321323 var error = true;
322324 var amount = $("input[name=amount]").val(); // get the amount
323325 var otherAmount = amount // create a working copy

Status & tagging log