r97205 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97204‎ | r97205 | r97206 >
Date:21:05, 15 September 2011
Author:foxtrott
Status:deferred
Tags:
Comment:
followup r97088: some more css tinkering to get scrolling working, fix for Cavendish skin
Modified paths:
  • /trunk/extensions/SemanticForms/libs/SF_popupform.js (modified) (history)
  • /trunk/extensions/SemanticForms/skins/SF_popupform.css (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/skins/SF_popupform.css
@@ -42,7 +42,6 @@
4343 height: 100%;
4444 border: none;
4545 background: transparent;
46 - overflow: hidden;
4746 }
4847
4948 iframe.popupform-innerdocument {
@@ -50,7 +49,6 @@
5150 height: 100%;
5251 border: none;
5352 background: transparent;
54 - position: relative;
5553 overflow: hidden;
5654 }
5755
Index: trunk/extensions/SemanticForms/libs/SF_popupform.js
@@ -209,15 +209,18 @@
210210
211211 // GuMaxDD has #content but keeps headlines in #gumax-content-body
212212 content = iframecontents.find("#gumax-content-body");
213 -
 213+
214214 // normal skins use #content (e.g. Vector, Monobook)
215215 if ( content.length == 0 ) content = iframecontents.find("#content");
216216
217217 // some skins use #mw_content (e.g. Modern)
218218 if ( content.length == 0 ) content = iframecontents.find("#mw_content");
219219
 220+ var iframebody = content.closest("body");
 221+ var iframedoc = iframebody.parent();
 222+
220223 // this is not a normal MW page (or it uses an unknown skin)
221 - if ( content.length == 0 ) content = iframecontents.find("body");
 224+ if ( content.length == 0 ) content = iframebody;
222225
223226 // the huge left margin looks ugly in Vector, reduce it
224227 // (How does this look for other skins?)
@@ -229,21 +232,31 @@
230233 height: "auto",
231234 minWidth: "0px",
232235 minHeight:"0px",
233 - overflow: "visible",
234 - position: "relative",
235 - top: "0",
236 - left: "0",
 236+// overflow: "visible",
 237+// position: "relative",
 238+// top: "0",
 239+// left: "0",
237240 border: "none"
238241 } )
239 - .parents('body').css( {
 242+ .parentsUntil('html')
 243+ .css( {
240244 margin: 0,
241245 padding: 0,
 246+ width: "auto",
 247+ height: "auto",
242248 minWidth: "0px",
243 - minHeight:"0px",
 249+ minHeight: "0px",
 250+ "float": "none", // Cavendish skin uses floating -> unfloat content
 251+// position: "relative",
 252+// top: "0",
 253+// left: "0",
244254 background: "transparent"
245255 })
246256 .andSelf().siblings();
247257
 258+ iframedoc.height('100%').width('100%');
 259+ iframebody.height('100%').width('100%');
 260+
248261 if ( jQuery.browser.msie && jQuery.browser.version < "8" ) {
249262 siblings.hide();
250263 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97088bugfix (popup does not scroll in latest FF)foxtrott19:22, 14 September 2011