r97167 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97166‎ | r97167 | r97168 >
Date:16:05, 15 September 2011
Author:dantman
Status:deferred
Tags:
Comment:
Fix a few mPage references in recently ported code.
Modified paths:
  • /branches/pageoutput/includes/view/ArticlePageView.php (modified) (history)

Diff [purge]

Index: branches/pageoutput/includes/view/ArticlePageView.php
@@ -710,7 +710,7 @@
711711 * \<- Previous version | Next Version -\>
712712 */
713713 public function setOldSubtitle() {
714 - if ( !wfRunHooks( 'DisplayOldSubtitle', array( &$this, &$oldid ) ) ) {
 714+ if ( !wfRunHooks( 'DisplayOldSubtitle', array( &$this, &$oldid ) ) ) { // @fixme
715715 return;
716716 }
717717
@@ -882,7 +882,7 @@
883883 public function outputWikiText( $text, $cache = true, $parserOptions = false ) {
884884 $this->mParserOutput = $this->getOutputFromWikitext( $text, $cache, $parserOptions );
885885
886 - $this->doCascadeProtectionUpdates( $this->mParserOutput );
 886+ $this->getPage()->doCascadeProtectionUpdates( $this->mParserOutput );
887887
888888 $this->getOutput()->addParserOutput( $this->mParserOutput );
889889 }
@@ -901,7 +901,7 @@
902902 global $wgParser, $wgEnableParserCache, $wgUseFileCache;
903903
904904 if ( !$parserOptions ) {
905 - $parserOptions = $this->mPage->getParserOptions();
 905+ $parserOptions = $this->getPage()->getParserOptions();
906906 }
907907
908908 $time = - wfTime();
@@ -928,7 +928,7 @@
929929 }
930930
931931 if ( $this->isCurrent() ) {
932 - $this->mPage->doCascadeProtectionUpdates( $this->mParserOutput );
 932+ $this->getPage()->doCascadeProtectionUpdates( $this->mParserOutput );
933933 }
934934
935935 return $this->mParserOutput;
@@ -945,7 +945,7 @@
946946 public function tryDirtyCache() {
947947 $out = $this->getOutput();
948948 $parserCache = ParserCache::singleton();
949 - $options = $this->mPage->getParserOptions();
 949+ $options = $this->getPage()->getParserOptions();
950950
951951 if ( $out->isPrintable() ) {
952952 $options->setIsPrintable( true );

Status & tagging log