r97165 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97164‎ | r97165 | r97166 >
Date:15:55, 15 September 2011
Author:ialex
Status:ok
Tags:
Comment:
* Factorise calls to get the User object
* Call Linker method statically
Modified paths:
  • /trunk/phase3/skins/Nostalgia.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Nostalgia.php
@@ -86,9 +86,10 @@
8787 $s .= $sep . Linker::specialLink( 'Userlogin' );
8888 } else {
8989 /* show user page and user talk links */
90 - $s .= $sep . Linker::link( $this->getSkin()->getUser()->getUserPage(), wfMsgHtml( 'mypage' ) );
91 - $s .= $sep . Linker::link( $this->getSkin()->getUser()->getTalkPage(), wfMsgHtml( 'mytalk' ) );
92 - if ( $this->getSkin()->getUser()->getNewtalk() ) {
 90+ $user = $this->getSkin()->getUser();
 91+ $s .= $sep . Linker::link( $user->getUserPage(), wfMsgHtml( 'mypage' ) );
 92+ $s .= $sep . Linker::link( $user->getTalkPage(), wfMsgHtml( 'mytalk' ) );
 93+ if ( $user->getNewtalk() ) {
9394 $s .= ' *';
9495 }
9596 /* show watchlist link */
@@ -100,12 +101,12 @@
101102 /* show my preferences link */
102103 $s .= $sep . Linker::specialLink( 'Preferences' );
103104 /* show upload file link */
104 - if( UploadBase::isEnabled() && UploadBase::isAllowed( $this->getSkin()->getUser() ) === true ) {
 105+ if( UploadBase::isEnabled() && UploadBase::isAllowed( $user ) === true ) {
105106 $s .= $sep . $this->getUploadLink();
106107 }
107108
108109 /* show log out link */
109 - $s .= $sep . $this->getSkin()->specialLink( 'Userlogout' );
 110+ $s .= $sep . Linker::specialLink( 'Userlogout' );
110111 }
111112
112113 $s .= $sep . $this->specialPagesList();

Follow-up revisions

RevisionCommit summaryAuthorDate
r97173Merged revisions 97087,97091-97092,97094,97096-97098,97100-97101,97103,97136,...dantman16:19, 15 September 2011

Status & tagging log