r97163 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97162‎ | r97163 | r97164 >
Date:15:50, 15 September 2011
Author:catrope
Status:ok
Tags:
Comment:
RL2: Followup r97154, add dependencies for ext.gadgets.api
Modified paths:
  • /branches/RL2/extensions/Gadgets/Gadgets.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/Gadgets.php
@@ -146,7 +146,8 @@
147147 // Method to interact with API
148148 'ext.gadgets.api' => $gadResourceTemplate + array(
149149 'scripts' => 'ext.gadgets.api.js',
150 - 'dependencies' => 'mediawiki.util',
 150+ // Can't depend on user.tokens yet due to a bug in ResourceLoader (bug 30914)
 151+ 'dependencies' => array( 'mediawiki.util', 'mediawiki.Title'/*, 'user.tokens'*/ ),
151152 ),
152153 // jQuery plugin
153154 'jquery.createPropCloud' => $gadResourceTemplate + array(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97154RL2: Rewrite of ext.gadgets.api that Timo and I worked on together at http://......catrope14:17, 15 September 2011

Status & tagging log