r97118 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97117‎ | r97118 | r97119 >
Date:23:48, 14 September 2011
Author:inez
Status:deferred
Tags:
Comment:
contentWidth in this context make much more sense then blockWidth
Modified paths:
  • /trunk/parsers/wikidom/lib/synth/views/es.ContentView.js (modified) (history)

Diff [purge]

Index: trunk/parsers/wikidom/lib/synth/views/es.ContentView.js
@@ -215,11 +215,11 @@
216216 this.$rangeEnd.hide();
217217 } else {
218218 // Multiple line selection
219 - var blockWidth = this.$.width();
 219+ var contentWidth = this.$.width();
220220 this.$rangeStart.css( {
221221 'top': fromPosition.top,
222222 'left': fromPosition.left,
223 - 'width': blockWidth - fromPosition.left,
 223+ 'width': contentWidth - fromPosition.left,
224224 'height': fromPosition.bottom - fromPosition.top
225225 } ).show();
226226 this.$rangeEnd.css( {
@@ -232,7 +232,7 @@
233233 this.$rangeFill.css( {
234234 'top': fromPosition.bottom,
235235 'left': 0,
236 - 'width': blockWidth,
 236+ 'width': contentWidth,
237237 'height': toPosition.top - fromPosition.bottom
238238 } ).show();
239239 } else {

Status & tagging log