r97056 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97055‎ | r97056 | r97057 >
Date:13:27, 14 September 2011
Author:catrope
Status:ok
Tags:
Comment:
RL2: Remove TODO comment that was addressed by r96949
Modified paths:
  • /branches/RL2/extensions/Gadgets/GadgetHooks.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/GadgetHooks.php
@@ -194,9 +194,7 @@
195195 * @param $preferences Array: Preference descriptions
196196 */
197197 public static function getPreferences( $user, &$preferences ) {
198 - // TODO: Part of this is duplicated from registerModules(), factor out into the repo
199198 $repo = LocalGadgetRepo::singleton();
200 -
201199 $gadgets = $repo->getGadgetIds();
202200 $categories = array(); // array( category => array( desc => name ) )
203201 $default = array(); // array of Gadget ids

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96949RL2: Factor out $wgGadgetRepositories loop to GadgetRepo::getAllRepos() and i...catrope10:17, 13 September 2011

Status & tagging log