r97020 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97019‎ | r97020 | r97021 >
Date:22:37, 13 September 2011
Author:awjrichards
Status:ok (Comments)
Tags:
Comment:
Corrected incorrect token names and hidden form field values in webitects_1 rapid html form
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_1.html (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php
@@ -161,17 +161,14 @@
162162 $this->paypalRedirect( $data );
163163 return;
164164 }
165 -
166165 // dispatch forms/handling
167166 if ( $token_match ) {
168167 if ( $data['payment_method'] == 'processed' ) {
169168
170169 // increase the count of attempts
171170 ++$data['numAttempt'];
172 -
173171 // Check form for errors and redisplay with messages
174172 $form_errors = $this->fnPayflowValidateForm( $data, $this->errors );
175 -
176173 if ( $form_errors ) {
177174 $this->fnPayflowDisplayForm( $data, $this->errors );
178175 } else { // The submitted form data is valid, so process it
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_1.html
@@ -163,7 +163,7 @@
164164 <input type="hidden" value="@amount" name="amount" />
165165 <input type="hidden" value="US" name="country" id="country" />
166166
167 - <input type="hidden" value="@currency_code" name="currency_code" />
 167+ <input type="hidden" value="@currency_code" name="currency" />
168168 <input type="hidden" value="@utm_source" name="utm_source"/>
169169 <input type="hidden" value="@utm_medium" name="utm_medium"/>
170170 <input type="hidden" value="@utm_campaign" name="utm_campaign"/>
@@ -172,10 +172,10 @@
173173 <input type="hidden" value="@comment" name="comment"/>
174174 <input type="hidden" value="@comment-option" name="comment-option"/>
175175 <input type="hidden" value="@email-opt" name="email-opt"/>
176 - <input type="hidden" value="@payment_method" name="payment_method"/>
 176+ <input type="hidden" value="processed" name="payment_method"/>
177177 <input type="hidden" value="@token" name="token"/>
178178 <input type="hidden" value="@order_id" name="order_id"/>
179 - <input type="hidden" value="@num_attempt" name="numAttempt"/>
 179+ <input type="hidden" value="@numAttempt" name="numAttempt"/>
180180 <input type="hidden" value="@contribution_tracking_id" name="contribution_tracking_id"/>
181181 <input type="hidden" value="@data_hash" name="data_hash"/>
182182 <input type="hidden" value="@owa_session" name="owa_session"/>

Comments

#Comment by Khorn (WMF) (talk | contribs)   17:29, 6 October 2011

These values do, in fact, match up with what I've got in Donation Interface.

Status & tagging log