r96885 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96884‎ | r96885 | r96886 >
Date:19:03, 12 September 2011
Author:neilk
Status:ok
Tags:
Comment:
backporting patches for 1.17 - jpegmeta library not there, jquery buttons interface different
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/UploadWizard/UploadWizardHooks.php (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/UploadWizard/resources/jquery/jquery.mwCoolCats.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/UploadWizard/UploadWizardHooks.php
@@ -26,7 +26,6 @@
2727 'mediawiki.language',
2828 'mediawiki.Uri',
2929 'mediawiki.util',
30 - 'mediawiki.libs.jpegmeta',
3130 'ext.uploadwizard.mediawiki.language.parser',
3231 ),
3332 'scripts' => array(
Index: branches/wmf/1.17wmf1/extensions/UploadWizard/resources/jquery/jquery.mwCoolCats.js
@@ -31,21 +31,14 @@
3232 };
3333
3434 var confirmIt = function() {
35 - var buttons = [
36 - {
37 - text: gM( 'mw-coolcats-confirm-new-cancel' ),
38 - click: function() {
39 - $( this ).dialog( "close" );
40 - }
41 - },
42 - {
43 - text: gM( 'mw-coolcats-confirm-new-ok' ),
44 - click: function() {
45 - insertIt();
46 - $( this ).dialog( "close" );
47 - }
48 - }
49 - ];
 35+ var buttons = {};
 36+ buttons[ gM( 'mw-coolcats-confirm-new-cancel' ) ] = function() {
 37+ $( this ).dialog( "close" );
 38+ };
 39+ buttons[ gM( 'mw-coolcats-confirm-new-ok' ) ] = function() {
 40+ insertIt();
 41+ $( this ).dialog( "close" );
 42+ };
5043 $j( '<div></div>' )
5144 .msg( 'mw-coolcats-confirm-new', title.getMainText() )
5245 .dialog( {

Status & tagging log