r96868 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96867‎ | r96868 | r96869 >
Date:17:12, 12 September 2011
Author:catrope
Status:ok
Tags:
Comment:
RL2: Fix breakage in r96852: can't use getMemcKey() in the constructor when $this->hasSharedCache hasn't been initialized yet
Modified paths:
  • /branches/RL2/extensions/Gadgets/backend/ForeignDBGadgetRepo.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/backend/ForeignDBGadgetRepo.php
@@ -16,7 +16,7 @@
1717 class ForeignDBGadgetRepo extends LocalGadgetRepo {
1818 protected $db = null;
1919
20 - protected $source, $dbServer, $dbUser, $dbPassword, $dbName, $dbFlags, $tablePrefix/*, $hasSharedCache*/;
 20+ protected $source, $dbServer, $dbUser, $dbPassword, $dbName, $dbFlags, $tablePrefix, $hasSharedCache;
2121
2222 /**
2323 * Constructor.
@@ -25,13 +25,13 @@
2626 public function __construct( array $options ) {
2727 parent::__construct( $options );
2828
29 - $this->namesKey = $this->getMemcKey( 'gadgets', 'foreigndbreponames' );
30 -
3129 $optionKeys = array( 'source', 'dbType', 'dbServer', 'dbUser', 'dbPassword', 'dbName',
3230 'dbFlags', 'tablePrefix', 'hasSharedCache' );
3331 foreach ( $optionKeys as $optionKey ) {
3432 $this->{$optionKey} = $options[$optionKey];
3533 }
 34+
 35+ $this->namesKey = $this->getMemcKey( 'gadgets', 'foreigndbreponames' );
3636 }
3737
3838 public function isWriteable() {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96852RL2: Followup r96837: fix ugliness in dealing with ForeignDBRepo names cachin...catrope15:17, 12 September 2011

Status & tagging log