r96818 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r96817‎ | r96818 | r96819 >
Date:22:49, 11 September 2011
Author:jeroendedauw
Status:resolved (Comments)
Tags:
Comment:
Follow up to r96815;
Modified paths:
  • /trunk/extensions/Survey/specials/SpecialSurveyPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Survey/specials/SpecialSurveyPage.php
——@@ -114,7 +114,7 @@
115115 * @param array $links
116116 */
117117 protected function displayNavigation( array $links ) {
118 - $this->getOutput()->addHTML( Html::rawElement( 'p', array(), implode( ' - ', $links ) ) );
 118+ $this->getOutput()->addHTML( Html::rawElement( 'p', array(), $GLOBALS['wgLang']->pipeList( $links ) ) );
119119 }
120120
121121 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r96819Follow up to r96818;jeroendedauw23:57, 11 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96815navigation++jeroendedauw22:10, 11 September 2011

Comments

#Comment by Krinkle (talk | contribs)   23:08, 11 September 2011

SpecialPages are connected to the wiki context as of MediaWiki 1.18. Use SpecialPage->getLang() instead of the globals. $this->getLang() in this case. This ensures that the right context is used.

#Comment by Jeroen De Dauw (talk | contribs)   23:58, 11 September 2011

Neat; made use of that in follow up :)

Status & tagging log