r96800 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96799‎ | r96800 | r96801 >
Date:18:20, 11 September 2011
Author:nikerabbit
Status:deferred
Tags:
Comment:
Fix wrong message param (should refer to the base page, not the page that was just deleted)
Modified paths:
  • /trunk/extensions/Translate/tag/DeleteJob.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/DeleteJob.php
@@ -23,7 +23,7 @@
2424 $job->setFull( $full );
2525 $job->setBase( $base );
2626 $msg = $job->getFull() ? 'pt-deletepage-full-logreason' : 'pt-deletepage-lang-logreason';
27 - $job->setSummary( wfMsgForContent( $msg, $target->getPrefixedText() ) );
 27+ $job->setSummary( wfMsgForContent( $msg, $base ) );
2828 $job->setPerformer( $performer );
2929 return $job;
3030 }
@@ -53,7 +53,7 @@
5454 $logger = new LogPage( 'pagetranslation' );
5555 $params = array(
5656 'user' => $this->getPerformer(),
57 - 'target' => $title->getPrefixedText(),
 57+ 'target' => $base,
5858 'error' => base64_encode( serialize( $ok ) ), // This is getting ridiculous
5959 );
6060 $doer = User::newFromName( $this->getPerformer() );

Status & tagging log