r96776 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96775‎ | r96776 | r96777 >
Date:09:46, 11 September 2011
Author:nikerabbit
Status:deferred
Tags:
Comment:
Ping r96752. Fix two already broken tests and one that was broken in that revision.
Modified paths:
  • /trunk/extensions/Translate/tests/MessageGroupBaseTest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tests/MessageGroupBaseTest.php
@@ -18,7 +18,7 @@
1919 }
2020
2121 protected function tearDown() {
22 - unset( $this->apple );
 22+ unset( $this->group );
2323 parent::tearDown();
2424 }
2525
@@ -56,10 +56,11 @@
5757
5858 public function testGetNamespaceNumber() {
5959 $conf = $this->groupConfiguration;
60 - $conf['BASIC']['namespace'] = NS_MEDIAWIKI;
 60+ $conf['BASIC']['namespace'] = NS_IMAGE;
 61+ $this->group = MessageGroupBase::factory( $conf );
6162
6263 $this->assertEquals(
63 - NS_MEDIAWIKI,
 64+ NS_IMAGE,
6465 $this->group->getNamespace(),
6566 "should parse integer namespace number."
6667 );
@@ -67,10 +68,11 @@
6869
6970 public function testGetNamespaceString() {
7071 $conf = $this->groupConfiguration;
71 - $conf['BASIC']['namespace'] = 'mediawiki';
 72+ $conf['BASIC']['namespace'] = 'image';
 73+ $this->group = MessageGroupBase::factory( $conf );
7274
7375 $this->assertEquals(
74 - NS_MEDIAWIKI,
 76+ NS_IMAGE,
7577 $this->group->getNamespace(),
7678 "should parse string namespace name."
7779 );
@@ -83,6 +85,7 @@
8486 public function testGetNamespaceInvalid() {
8587 $conf = $this->groupConfiguration;
8688 $conf['BASIC']['namespace'] = 'ergweofijwef';
 89+ MessageGroupBase::factory( $conf );
8790 }
8891
8992 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96752Kill unused globals/variables...reedy22:24, 10 September 2011

Status & tagging log