r96750 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96749‎ | r96750 | r96751 >
Date:22:09, 10 September 2011
Author:reedy
Status:ok
Tags:
Comment:
Simplify some contexts
Modified paths:
  • /trunk/phase3/skins/Simple.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Simple.php
@@ -33,12 +33,12 @@
3434 $rules = array();
3535 $underline = "";
3636
37 - if ( $this->getSkin()->getUser()->getOption( 'underline' ) < 2 ) {
38 - $underline = "text-decoration: " . $this->getSkin()->getUser()->getOption( 'underline' ) ? 'underline !important' : 'none' . ";";
 37+ if ( $this->getUser()->getOption( 'underline' ) < 2 ) {
 38+ $underline = "text-decoration: " . $this->getUser()->getOption( 'underline' ) ? 'underline !important' : 'none' . ";";
3939 }
4040
4141 /* Also inherits from resourceloader */
42 - if( !$this->getSkin()->getUser()->getOption( 'highlightbroken' ) ) {
 42+ if( !$this->getUser()->getOption( 'highlightbroken' ) ) {
4343 $rules[] = "a.new, a.stub { color: inherit; text-decoration: inherit;}";
4444 $rules[] = "a.new:after { color: #CC2200; $underline;}";
4545 $rules[] = "a.stub:after { $underline; }";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96669Kill off $wg{Request,User,Lang,Output} usage within skins/ and redundant $thi...dantman15:41, 9 September 2011

Status & tagging log