r96697 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96696‎ | r96697 | r96698 >
Date:21:25, 9 September 2011
Author:aaron
Status:ok
Tags:
Comment:
Renamed Rev_List/Rev_Item classes to RevisionListBase/RevisionItemBase
Modified paths:
  • /trunk/phase3/includes/AutoLoader.php (modified) (history)
  • /trunk/phase3/includes/RevisionList.php (modified) (history)
  • /trunk/phase3/includes/revisiondelete/RevisionDeleteAbstracts.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/revisiondelete/RevisionDeleteAbstracts.php
@@ -6,7 +6,7 @@
77 * relevant rows, to return RevDel_Item subclasses wrapping them, and
88 * to wrap bulk update operations.
99 */
10 -abstract class RevDel_List extends Rev_List {
 10+abstract class RevDel_List extends RevisionListBase {
1111 function __construct( RequestContext $context, Title $title, array $ids ) {
1212 parent::__construct( $context, $title );
1313 $this->ids = $ids;
@@ -242,7 +242,7 @@
243243 /**
244244 * Abstract base class for deletable items
245245 */
246 -abstract class RevDel_Item extends Rev_Item {
 246+abstract class RevDel_Item extends RevisionItemBase {
247247 /**
248248 * Returns true if the item is "current", and the operation to set the given
249249 * bits can't be executed for that reason
Index: trunk/phase3/includes/AutoLoader.php
@@ -186,8 +186,8 @@
187187 'Replacer' => 'includes/StringUtils.php',
188188 'RequestContext' => 'includes/RequestContext.php',
189189 'ReverseChronologicalPager' => 'includes/Pager.php',
190 - 'Rev_Item' => 'includes/RevisionList.php',
191 - 'Rev_List' => 'includes/RevisionList.php',
 190+ 'RevisionItemBase' => 'includes/RevisionList.php',
 191+ 'RevisionListBase' => 'includes/RevisionList.php',
192192 'Revision' => 'includes/Revision.php',
193193 'RevisionList' => 'includes/RevisionList.php',
194194 'RSSFeed' => 'includes/Feed.php',
Index: trunk/phase3/includes/RevisionList.php
@@ -2,7 +2,7 @@
33 /**
44 * List for revision table items for a single page
55 */
6 -abstract class Rev_List {
 6+abstract class RevisionListBase {
77 /**
88 * @var Title
99 */
@@ -127,15 +127,15 @@
128128 /**
129129 * Abstract base class for revision items
130130 */
131 -abstract class Rev_Item {
132 - /** The parent Rev_List */
 131+abstract class RevisionItemBase {
 132+ /** The parent RevisionListBase */
133133 var $list;
134134
135135 /** The DB result row */
136136 var $row;
137137
138138 /**
139 - * @param $list Rev_List
 139+ * @param $list RevisionListBase
140140 * @param $row DB result row
141141 */
142142 public function __construct( $list, $row ) {
@@ -240,7 +240,7 @@
241241 abstract public function getHTML();
242242 }
243243
244 -class RevisionList extends Rev_List {
 244+class RevisionList extends RevisionListBase {
245245 public function getType() {
246246 return 'revision';
247247 }
@@ -274,7 +274,7 @@
275275 /**
276276 * Item class for a live revision table row
277277 */
278 -class RevisionItem extends Rev_Item {
 278+class RevisionItem extends RevisionItemBase {
279279 var $revision, $context;
280280
281281 public function __construct( $list, $row ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91344* Added generic Rev_List revision listing class and refactored RevDelete_List...aaron09:04, 2 July 2011

Status & tagging log