r96690 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96689‎ | r96690 | r96691 >
Date:20:19, 9 September 2011
Author:maxsem
Status:ok
Tags:
Comment:
<font>, eh?
Modified paths:
  • /trunk/extensions/wikihiero/wikihiero.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/wikihiero/wikihiero.body.php
@@ -177,7 +177,7 @@
178178 if ( array_key_exists( $code, self::$files ) ) {
179179 return "<img {$imageClass}style='margin:" . WH_IMG_MARGIN . "px;' $option src='" . htmlspecialchars( WH_IMG_DIR . WH_IMG_PRE . "{$code}." . self::IMG_EXT ) . "' title='" . htmlspecialchars( "{$code} [{$glyph}]" ) . "' alt='" . htmlspecialchars( $glyph ) . "' />";
180180 } else {
181 - return "<font title='" . htmlspecialchars( $code ) . "'>" . htmlspecialchars( $glyph ) . "</font>";
 181+ return htmlspecialchars( $glyph );
182182 }
183183 } elseif ( array_key_exists( $glyph, self::$files ) ) {
184184 return "<img {$imageClass}style='margin:" . WH_IMG_MARGIN . "px;' $option src='" . htmlspecialchars( WH_IMG_DIR . WH_IMG_PRE . "{$glyph}." . self::IMG_EXT ) . "' title='" . htmlspecialchars( $glyph ) . "' alt='" . htmlspecialchars( $glyph ) . "' />";

Status & tagging log