r96661 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96660‎ | r96661 | r96662 >
Date:14:07, 9 September 2011
Author:catrope
Status:ok
Tags:
Comment:
RL2: Some typo fixes in the JS files introduced in r96309
Modified paths:
  • /branches/RL2/extensions/Gadgets/modules/ext.gadgets.gadgetmanager.api.js (modified) (history)
  • /branches/RL2/extensions/Gadgets/modules/ext.gadgets.gadgetmanager.ui.js (modified) (history)
  • /branches/RL2/extensions/Gadgets/modules/jquery.createPropCloud.js (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/modules/jquery.createPropCloud.js
@@ -68,18 +68,18 @@
6969 $cloud = $input.wrap( '<div class="' + o.prefix + 'propcloud"></div>' ).parent(),
7070 $container = $( '<div class="' + o.prefix + 'propcontainer"></div>' );
7171
72 - // Append while container is still off the dom
73 - // This is faster and prevents visible build up
 72+ // Append while container is still off the DOM
 73+ // This is faster and prevents visible build-up
7474 for ( var i = 0, props = o.props, len = props.length; i < len; i++ ) {
7575 $container.append( newPropHtml( '' + props[i], o ) );
7676 }
7777
7878 $input.autocomplete( {
79 - // The source is entirly up to you
 79+ // The source is entirely up to you
8080 source: o.autocompleteSource,
8181
8282 // A value is choosen
83 - // (ie. by pressing return/tab, clicking on suggestion, etc.)
 83+ // (e.g. by pressing return/tab, clicking on suggestion, etc.)
8484 select: function( e, data ){
8585 var val = data.item.value;
8686
Index: branches/RL2/extensions/Gadgets/modules/ext.gadgets.gadgetmanager.api.js
@@ -20,8 +20,8 @@
2121
2222 /**
2323 * For most returns from api.* functions, a clone is made when data from
24 - * cached is used. This is to avoid situations where later modifications
25 - * (ie. by the ajax editor) on the object affecting the cache (because
 24+ * cache is used. This is to avoid situations where later modifications
 25+ * (e.g. by the AJAX editor) to the object affect the cache (because
2626 * the object would otherwise be passed by reference).
2727 */
2828 function objClone( obj ) {
@@ -34,10 +34,10 @@
3535 * var a = { words: [ 'foo', 'bar','baz' ] };
3636 * var b = $.extend( {}, a );
3737 * b.words.push( 'quux' );
38 - * a.words[4]; // quux !
 38+ * a.words[3]; // quux !
3939 * </code>
4040 */
41 - return $.extend( true /* resursive */, {}, obj );
 41+ return $.extend( true /* recursive */, {}, obj );
4242 }
4343 function arrClone( arr ) {
4444 return arr.slice();
@@ -151,7 +151,7 @@
152152 * - blob {Object} Gadget meta data
153153 * @param callback {Function} Called with two arguments:
154154 * - status ('ok' or 'error')
155 - * - msg (localized, something like "Successfull", "Conflict occurred" etc.)
 155+ * - msg (localized, something like "Successful", "Conflict occurred" etc.)
156156 * @return {jqXHR|Null}: Null if served from cache, otherwise the jqXHR.
157157 */
158158 doModifyGadget: function( gadget, callback ) {
Index: branches/RL2/extensions/Gadgets/modules/ext.gadgets.gadgetmanager.ui.js
@@ -117,7 +117,7 @@
118118
119119 gm.ui = {
120120 /**
121 - * Initilizes the the page. For now just binding click handlers
 121+ * Initializes the the page. For now just binding click handlers
122122 * to the anchor tags in the table.
123123 */
124124 initUI: function() {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96309[ResourceLoader2] Gadget manager (start of ajax editor)...krinkle22:28, 5 September 2011

Status & tagging log