r96656 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96655‎ | r96656 | r96657 >
Date:11:32, 9 September 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: MFT r96655, which was a commit of a live hack to begin with
Modified paths:
  • /branches/wmf/1.17wmf1/includes/parser/Preprocessor_DOM.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/parser/Preprocessor_DOM.php
@@ -134,7 +134,8 @@
135135 if ( !$result ) {
136136 // Try running the XML through UtfNormal to get rid of invalid characters
137137 $xml = UtfNormal::cleanUp( $xml );
138 - $result = $dom->loadXML( $xml );
 138+ // 1 << 19 == XML_PARSE_HUGE, needed so newer versions of libxml2 don't barf when the XML is >256 levels deep
 139+ $result = $dom->loadXML( $xml, 1 << 19 );
139140 if ( !$result ) {
140141 throw new MWException( __METHOD__.' generated invalid XML' );
141142 }
Property changes on: branches/wmf/1.17wmf1/includes/parser/Preprocessor_DOM.php
___________________________________________________________________
Added: svn:mergeinfo
142143 Merged /branches/sqlite/includes/parser/Preprocessor_DOM.php:r58211-58321
143144 Merged /trunk/phase3/includes/parser/Preprocessor_DOM.php:r83590,89512-89513,96655
144145 Merged /branches/new-installer/phase3/includes/parser/Preprocessor_DOM.php:r43664-66004
145146 Merged /branches/wmf-deployment/includes/parser/Preprocessor_DOM.php:r53381,60970
146147 Merged /branches/REL1_15/phase3/includes/parser/Preprocessor_DOM.php:r51646
147148 Merged /branches/wmf/1.16wmf4/includes/parser/Preprocessor_DOM.php:r67177,69199,76243,77266

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96655Commit live hack: pass XML_PARSE_HUGE (code uses 1 << 19 because the constant...catrope11:28, 9 September 2011

Status & tagging log