r96649 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r96648‎ | r96649 | r96650 >
Date:08:04, 9 September 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
This should fix regression reported in r96545
Notice: Undefined offset: 1 in D:\www\MW_trunk\phase3\extensions\FlaggedRevs\dataclasses\FlaggedRevsLog.php on line 156
Modified paths:
  • /trunk/phase3/includes/logging/LogEntry.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/logging/LogEntry.php
——@@ -215,7 +215,7 @@
216216 $this->params = $params;
217217 $this->legacy = false;
218218 } else {
219 - $this->params = explode( "\n", $blob );
 219+ $this->params = $blob === '' ? array() : explode( "\n", $blob );
220220 $this->legacy = true;
221221 }
222222 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96545Use LogFormatter to format log entries....nikerabbit08:57, 8 September 2011

Status & tagging log