r96631 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96630‎ | r96631 | r96632 >
Date:23:40, 8 September 2011
Author:kaldari
Status:ok
Tags:fundraising 
Comment:
fixing some paths
Modified paths:
  • /branches/fundraising/extensions/DonationInterface/gateway_forms/RapidHtml.php (modified) (history)
  • /branches/fundraising/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetter3.php (modified) (history)
  • /branches/fundraising/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.php (modified) (history)

Diff [purge]

Index: branches/fundraising/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetter3.php
@@ -359,7 +359,7 @@
360360 }
361361
362362 public function generateStateDropdown() {
363 - require_once( dirname( __FILE__ ) . '/../includes/stateAbbreviations.inc' );
 363+ require_once( dirname( __FILE__ ) . '/includes/stateAbbreviations.inc' );
364364
365365 $states = statesMenuXML();
366366
Index: branches/fundraising/extensions/DonationInterface/gateway_forms/RapidHtml.php
@@ -227,10 +227,10 @@
228228 * @param string $file_name
229229 */
230230 public function set_html_file_path( $file_name ) {
231 - global $wgPayflowProHtmlFormDir, $wgPayflowProGatewayAllowedHtmlForms;
232 -
 231+ global $wgGlobalCollectGatewayHtmlFormDir, $wgGlobalCollectGatewayAllowedHtmlForms;
 232+
233233 // Get the dirname - the "/." helps ensure we get a consistent path name with no trailing slash
234 - $html_dir = dirname( $wgPayflowProHtmlFormDir . "/." );
 234+ $html_dir = dirname( $wgGlobalCollectGatewayHtmlFormDir . "/." );
235235
236236 if ( !is_dir( $html_dir )) {
237237 throw new MWException( 'Requested form directory does not exist.' );
@@ -243,7 +243,7 @@
244244 $full_path = $html_dir . '/' . $file_name . '.html';
245245
246246 // ensure that the full file path is actually whitelisted and exists
247 - if ( !in_array( $full_path, $wgPayflowProGatewayAllowedHtmlForms ) || !file_exists( $full_path ) ) {
 247+ if ( !in_array( $full_path, $wgGlobalCollectGatewayAllowedHtmlForms ) || !file_exists( $full_path ) ) {
248248 throw new MWException( 'Requested an unavailable or non-existent form.' );
249249 }
250250
Index: branches/fundraising/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.php
@@ -99,7 +99,7 @@
100100 * Directory for HTML forms (used by RapidHtml form class)
101101 * @var string
102102 */
103 -$wgGlobalCollectGatewayHtmlFormDir = dirname( __FILE__ ) . "/forms/html";
 103+$wgGlobalCollectGatewayHtmlFormDir = dirname( __FILE__ ) . "/../gateway_forms/html";
104104
105105 /**
106106 * An array of allowed HTML forms.

Status & tagging log