r96601 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96600‎ | r96601 | r96602 >
Date:19:28, 8 September 2011
Author:aaron
Status:ok
Tags:
Comment:
Partial revert of r65898 (bug 27700). Callers should check 'create' and Title will internally check the proper subpermission depending on the title namespace.
Modified paths:
  • /trunk/phase3/includes/upload/UploadBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadBase.php
@@ -478,7 +478,7 @@
479479 $permErrors = $nt->getUserPermissionsErrors( 'edit', $user );
480480 $permErrorsUpload = $nt->getUserPermissionsErrors( 'upload', $user );
481481 if ( !$nt->exists() ) {
482 - $permErrorsCreate = $nt->getUserPermissionsErrors( 'createpage', $user );
 482+ $permErrorsCreate = $nt->getUserPermissionsErrors( 'create', $user );
483483 } else {
484484 $permErrorsCreate = array();
485485 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65898Fix for r65818: the proper permission is 'createpage', not 'create'. Skip che...btongminh14:48, 4 May 2010
r82853(bug 27700) The upload protection can now also be set for files that do not e...btongminh13:51, 26 February 2011

Status & tagging log