r96568 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96567‎ | r96568 | r96569 >
Date:14:46, 8 September 2011
Author:catrope
Status:ok
Tags:
Comment:
Remove duplicate building of $checkbox introduced in r96142
Modified paths:
  • /trunk/extensions/Narayam/js/ext.narayam.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/js/ext.narayam.core.js
@@ -544,11 +544,6 @@
545545 // If rtl, add to the right of top personal links. Else, to the left
546546 var fn = $( 'body' ).hasClass( 'rtl' ) ? "append" : "prepend";
547547 $( '#p-personal ul:first' )[fn]( $li );
548 - // Build enable/disable checkbox and label
549 - $checkbox = $( '<input type="checkbox" id="narayam-toggle" />' );
550 - $checkbox
551 - .attr( 'title', mw.msg( 'narayam-checkbox-tooltip' ) )
552 - .click( that.toggle );
553548 // Workaround for IE bug - activex components like input fields
554549 // coming on top of everything.
555550 // TODO: is there a better solution other than hiding it on hover?

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96142Change position of Narayam controls to personal tools/menu area as proposed b...junaidpv19:31, 2 September 2011

Status & tagging log