r96484 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r96483
|
r96484
|
r96485
>
Date:
20:13, 7 September 2011
Author:
hashar
Status:
ok
Tags:
Comment:
show chunk causing diffhighlight to throw an exception
also added a test representing krinkle comment on
r94951
.
Modified paths:
/trunk/extensions/CodeReview/backend/DiffHighlighter.php
(modified) (
history
)
/trunk/extensions/CodeReview/tests/DiffHighlighterTest.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/CodeReview/backend/DiffHighlighter.php
—
—
@@ -299,7 +299,7 @@
300
300
if( $matches !== 1 ) {
301
301
# We really really should have matched something!
302
302
throw new MWException(
303
- __METHOD__ . " given an invalid chunk header \n"
303
+ __METHOD__ . " given an invalid chunk header: '$chunkHeader'\n"
304
304
);
305
305
}
306
306
return $m;
Index: trunk/extensions/CodeReview/tests/DiffHighlighterTest.php
—
—
@@ -22,6 +22,10 @@
23
23
array( 76, 17, 76, 21 ),
24
24
'@@ -76,17 +76,21 @@'
25
25
),
26
+ array(
27
+ array( 1, 63, 0, 0 ),
28
+ '@@ -1,63 +0,0 @@'
29
+ ),
26
30
);
27
31
}
28
32
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r94951
new method to parse chunk delimiters...
hashar
21:28, 18 August 2011
Status & tagging log
22:22, 8 December 2011
Tim Starling
(
talk
|
contribs
)
changed the
status
of r96484
[
removed:
new
added:
ok]