r96466 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96465‎ | r96466 | r96467 >
Date:18:39, 7 September 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: MFT r95332, r95451
Modified paths:
  • /branches/wmf/1.17wmf1/resources/mediawiki.util/mediawiki.util.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/resources/mediawiki.util/mediawiki.util.js
@@ -150,7 +150,9 @@
151151 var re = new RegExp( '^[^#]*[&?]' + $.escapeRE( param ) + '=([^&#]*)' );
152152 var m = re.exec( url );
153153 if ( m && m.length > 1 ) {
154 - return decodeURIComponent( m[1] );
 154+ // Beware that decodeURIComponent is not required to understand '+'
 155+ // by spec, as encodeURIComponent does not produce it.
 156+ return decodeURIComponent( m[1].replace( /\+/g, '%20' ) );
155157 }
156158 return null;
157159 },
Property changes on: branches/wmf/1.17wmf1/resources/mediawiki.util/mediawiki.util.js
___________________________________________________________________
Modified: svn:mergeinfo
158160 Merged /trunk/phase3/resources/mediawiki/mediawiki.util.js:r95332,95451

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95332* (bug 30441) getParamValue must understand "+" encoding of space...brion20:17, 23 August 2011
r95451Followup r95332 (bug 30441 fix) -- Roan pointed out that I forgot to do a glo...brion22:09, 24 August 2011

Status & tagging log