r96452 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96451‎ | r96452 | r96453 >
Date:17:11, 7 September 2011
Author:siebrand
Status:ok
Tags:
Comment:
Follow-up CR comment by Nikerabbit on r96433: Do not rely on implicit conversion of message object to string; explicit parse().
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserrights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserrights.php
@@ -447,7 +447,7 @@
448448 Html::hidden( 'wpEditToken', $this->getUser()->editToken( $this->mTarget ) ) .
449449 Xml::openElement( 'fieldset' ) .
450450 Xml::element( 'legend', array(), wfMsg( 'userrights-editusergroup' ) ) .
451 - wfMessage( 'editinguser' )->params( wfEscapeWikiText( $user->getName() ) )->rawParams( $userToolLinks ) .
 451+ wfMessage( 'editinguser' )->params( wfEscapeWikiText( $user->getName() ) )->rawParams( $userToolLinks )->parse() .
452452 wfMsgExt( 'userrights-groups-help', array( 'parse' ) ) .
453453 $grouplist .
454454 Xml::tags( 'p', null, $this->groupCheckboxes( $groups ) ) .

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96433Follow-up r96429: use wfMessage() to make it work properly. Previously $userT...siebrand13:52, 7 September 2011

Status & tagging log